linux-kernel - Re: [PATCH]: mce: don't print "human readable" message for corrected errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Apr 2011 15:24:09 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Borislav Petkov <bp@...en8.de>, Russ Anderson <rja@....com>,
	Prarit Bhargava <prarit@...hat.com>,
	"Luck, Tony" <tony.luck@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dzickus@...hat.com" <dzickus@...hat.com>,
	"mstowe@...hat.com" <mstowe@...hat.com>,
	"dnelson@...hat.com" <dnelson@...hat.com>, rja@...ricas.sgi.com
Subject: Re: [PATCH]: mce: don't print "human readable" message for corrected
 errors

On Wed, Apr 13, 2011 at 09:14:33AM +0200, Borislav Petkov wrote:

[..]

> So maybe we could drop the default notifier and do in print_mce():
> 
> 	if (notifier_chain_empty(&x86_mce_decoder_chain))
> 		pr_emerg(HW_ERR "Run the message through 'mcelog --ascii' to decode.\n");
> 
> I think this could work, let me cook up something.

Ok, I'm sending what I scratched up as a reply to this mail. They remove
the default notifier and use an atomic flag to distinguish the cases
between when we have a decoder or not.

This is marginally better in the sense that we don't have to call into
the notifier chain if there are no notifier calls on it so it saves us
a call in the UC case. Also, it drops the tainting for CEs and testing
this by injecting DRAM CECCs leaves /proc/sys/kernel/tainted at 0.

I still have to test the UC case but for that I'll have to dust off my
patchset which implements hw MCE injection first.

To be continued...

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/