lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 13 Apr 2011 06:36:24 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Jiri Pinkava <jiri.pinkava@...ht.cz>
Cc:	ben-linux@...ff.org, linux-kernel@...r.kernel.org,
	linux-mtd@...ts.infradead.org
Subject: Re: [PATCH] nand: Fix S3C NAND clock stop

On Mon, 2011-04-11 at 16:48 +0200, Jiri Pinkava wrote:
> Current implementation of s3c2410_nand_select_chip call
> clk_disable every time when chip = -1 (de-select). This happend
> multiple times even if chip was already de-selected. This causes
> disabling clock even if they are already disabled and due to
> nature of clock subsytem implementation this causes nand clock
> to be disabled and newer enabled again.
> 
> Signed-off-by: Jiri Pinkava <jiri.pinkava@...ht.cz>
> ---
>  drivers/mtd/nand/s3c2410.c |   59 ++++++++++++++++++++++++++++++++------------
>  1 files changed, 43 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
> index 33d832d..cea775a 100644
> --- a/drivers/mtd/nand/s3c2410.c
> +++ b/drivers/mtd/nand/s3c2410.c
> @@ -55,7 +55,7 @@ static int hardware_ecc = 0;
>  #endif
>  
>  #ifdef CONFIG_MTD_NAND_S3C2410_CLKSTOP
> -static int clock_stop = 1;
> +static const int clock_stop = 1;
>  #else
>  static const int clock_stop = 0;
>  #endif

Please, kill clock_stop variable completely in a separate patch.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux - Powered by OpenVZ