linux-kernel - Re: [Regression] 2.6.38 ncpfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Apr 2011 09:53:58 +0200
From:	"Bongani Hlope" <bonganih@...kservafrica.com>
To:	<torvalds@...ux-foundation.org>
Cc:	<arnd@...db.de>, <npiggin@...nel.dk>, <greg@...ah.com>,
	<hch@....de>, <bonganilinux@...b.co.za>, <rjw@...k.pl>,
	<bernd.feige@...klinik-freiburg.de>, <petr@...drovec.name>,
	<linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Regression] 2.6.38 ncpfs

Hi Linus

On Thu, 2011-04-14 at 13:22 -0700, Linus Torvalds wrote:
> On Thu, Apr 14, 2011 at 1:17 PM, Bongani Hlope
<bonganilinux@...b.co.za> wrote:
> >
> > Looking at the changes,  you are right. The BUG_ON() seems to be
what is not
> > suppose to be there. The attached patch only removes the BUG_ON().
I'll test
> > on my work PC tomorrow and see if that also fixes the bug.
> 
> You might also try to replace it with
> 
>     BUG_ON(!mutex_is_locked(&dentry->d_parent->d_inode->i_mutex))
> 
> ie add that "d_parent" there. Just for testing - I think the real fix
> really is to remove it, but I'd personally be happier knowing that
> _if_ it were to have that d_parent there, it would have worked.

I've made that change and ncpfs works fine with it. I've attached a
patch that changes the BUG_ON to look at the parent.

> 
> It would also be interesting to hear if that name length could
> possibly ever change, and we'd hit that test too. It looks like the
> original code actually checked that the length was the same before
> doing the overwrite.
> 
> ncpfs doesn't seem to be very actively maintained, I suspect Petr
> isn't really using it any more.
> 
>                    Linus
> 
>                 Linus
> --
> To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 



 
 
This e-mail and its attachments, if any, are subject to BankservAfrica's
e-mail disclaimer which is available on
http://www.bankservafrica.com/Contactus/EmailDisclaimer.aspx.
 
Please consider the environment before printing this e-mail!
View attachment "ncpfs.patch" of type "text/plain" (458 bytes)