| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Apr 2011 16:20:00 +0530 From: Viresh Kumar <viresh.kumar@...com> To: <linux-kernel@...r.kernel.org>, <vinod.koul@...el.com>, <dan.j.williams@...el.com> Cc: <linux-arm-kernel@...ts.infradead.org>, <armando.visconti@...com>, <shiraz.hashim@...com>, <amit.goel@...com>, <viresh.linux@...il.com>, <jamie@...ieiles.com>, <linux@....linux.org.uk>, Viresh Kumar <viresh.kumar@...com> Subject: [PATCH 2/6] dmaengine/dw_dmac: Enable resubmission from callback routine. Resubmission of new transfer must be allowed from callbacks. For this release lock before calling callback routine and enable them again. Signed-off-by: Viresh Kumar <viresh.kumar@...com> --- drivers/dma/dw_dmac.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c index 357265f..69a9c9d 100644 --- a/drivers/dma/dw_dmac.c +++ b/drivers/dma/dw_dmac.c @@ -242,12 +242,10 @@ dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc) } } - /* - * The API requires that no submissions are done from a - * callback, so we don't need to drop the lock here - */ + spin_unlock_irqrestore(&dwc->lock, dw->flags); if (callback) callback(param); + spin_lock_irqsave(&dwc->lock, dw->flags); } static void dwc_complete_all(struct dw_dma *dw, struct dw_dma_chan *dwc) -- 1.7.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists