linux-kernel - Re: [PATCH] mach-at91: gsia18s board improvements and bug fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Apr 2011 16:56:08 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Igor Plyatov <plyatov@...il.com>
CC:	Andrew Victor <linux@...im.org.za>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mach-at91: gsia18s board improvements and bug fixes

Hi Igor,

Le 20/04/2011 11:23, Igor Plyatov :
> * AT91_PIN_Pxxx port names replaced by human readable GPO_xxxx, GPI_xxxx,
>   GPIO_xxxx names. This simplify source code and schematic maintenance.

Maybe it simplifies schematic reading because the actual cpu pin names
are not indicated on your schematic... But for code, the AT91 pin names
are required, so, no for this part of the patch.
You may know that there is an effort ongoing to minimize the amount of
not needed / duplicated information in the kernel, I am afraid but I
think this renaming is not needed.

Moreover, I think that the "Buttons" part of the file:
arch/arm/mach-at91/include/mach/gsia18s.h
should be removed.

> * Active logic levels and default states corrected for GPOs.

Ok for this.

> * Replace small functions which use platform_register_device() by its direct
>   calls.

Ok for this.

> * Remove GPIO_CARD_UNMOUNT_1 gpio_keys_button, because it not used.

Ok for this.

> * debounce_interval added for critical buttons.

Ok for this.

> * Remove unneeded GPI setup code for buttons, because this done by corresponding
>   driver.

I do not see this, can you elaborate?

> * pcf8574x_0x20_setup() and pcf8574x_0x20_teardown functions small refactoring.

Ok for this.

> Signed-off-by: Igor Plyatov <plyatov@...il.com>

So, can you please rewrite your patch, we will be pleased to integrate
it in a "fix" update of at91 Linux.

Thanks, best regards,
-- 
Nicolas Ferre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/