lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 22 Apr 2011 02:20:33 -0700
From:	Joe Perches <joe@...ches.com>
To:	michal.simek@...alogix.com
Cc:	John Linn <john.linn@...inx.com>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, alan@...rguk.ukuu.org.uk,
	greg@...ah.com, Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH V2] tty/serial: add support for Xilinx PS UART

On Fri, 2011-04-22 at 11:11 +0200, Michal Simek wrote:
> John Linn wrote:
> > The Xilinx PS Uart is used on the new ARM based SoC. This
> > UART is not compatible with others such that a seperate
> > driver is required.
[]
> > +++ b/drivers/tty/serial/xilinx_uartps.c
[]
> > +		rc = uart_add_one_port(&xuartps_uart_driver, port);
> > +		if (rc) {
> > +			dev_err(&pdev->dev, "uart_add_one_port() failed; \
> > +						err=%i\n", rc);

That's a whitespace error.
Please don't be concerned about 80 column lines used for formatting.
You could use something like this as well.

			dev_err(&pdev->dev,
				"uart_add_one_port() failed; err=%d\n", rc);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists