linux-kernel - RE: [PATCH 6/8] staging/mei: Header file contain the Userland API, (IOCTL and its struct)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Apr 2011 17:12:45 +0300
From:	"Weil, Oren jer" <oren.jer.weil@...el.com>
To:	Greg KH <gregkh@...e.de>
CC:	Randy Dunlap <randy.dunlap@...cle.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alan@...ux.intel.com" <alan@...ux.intel.com>,
	"david@...dhou.se" <david@...dhou.se>
Subject: RE: [PATCH 6/8] staging/mei: Header file contain the Userland API,
 (IOCTL and its struct)

>> the reason that we use IOCTL is that we need to "associate" (Connect)
>> the current file description to a FW Client/Feature.  (opening a comm
>> channel) .
>
>As you didn't document this ioctl interface anywhere, saying exactly what you
>are trying to do, it makes it a bit hard to review your existing interface to
>determine that ioctls are the correct thing for your device.

>Care to document it, or at least describe it in the patches somewhere so we
>know it and can properly review it?

In the header file that I defined the IOCTL, I put a comment that describing 
the IOCTL.
Also in patch0 there is description about the use case of this IOCTL.
Tell me what kind of information you think that are missing and I will add it.
If needed I will add more information.

>
>> and in addition there is a security issue that we would like limit the
>> access to mei driver to system admins.
>>
>> From what I read we can't get those requirements with Netlinks, right?
>> If there other methods for achieving this ?
>
>sysfs, configfs, your own filesystem, etc.  There are lots of options.

Great, we are willing to hear any suggestions that people.
I'm willing to provide any information about the driver that is needed for the 
discussion.
.

---
Oren Weil - Intel Corporation.
http://www.intel.com

Download attachment "smime.p7s" of type "application/pkcs7-signature" (8587 bytes)

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.