linux-kernel - Re: [PATCH] m68k/atari: Do not use "/" in interrupt names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 04 May 2011 17:00:00 +0200
From:	Andreas Schwab <schwab@...ux-m68k.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linux/m68k <linux-m68k@...ts.linux-m68k.org>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k/atari: Do not use "/" in interrupt names

Geert Uytterhoeven <geert@...ux-m68k.org> writes:

> diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c
> index e1ada31..779efdc 100644
> --- a/arch/m68k/atari/atakeyb.c
> +++ b/arch/m68k/atari/atakeyb.c
> @@ -572,7 +572,7 @@ int atari_keyb_init(void)
>  	kb_state.len = 0;
>  
>  	error = request_irq(IRQ_MFP_ACIA, atari_keyboard_interrupt,
> -			    IRQ_TYPE_SLOW, "keyboard/mouse/MIDI",
> +			    IRQ_TYPE_SLOW, "keyboard:mouse:MIDI",

The name is not a path, but an enumeration, so the slash should probably
be changed to a comma instead.

> diff --git a/arch/m68k/atari/stdma.c b/arch/m68k/atari/stdma.c
> index 604329f..ad68fe9 100644
> --- a/arch/m68k/atari/stdma.c
> +++ b/arch/m68k/atari/stdma.c
> @@ -180,7 +180,7 @@ void __init stdma_init(void)
>  {
>  	stdma_isr = NULL;
>  	if (request_irq(IRQ_MFP_FDC, stdma_int, IRQ_TYPE_SLOW | IRQF_SHARED,
> -			"ST-DMA: floppy/ACSI/IDE/Falcon-SCSI", stdma_int))
> +			"ST-DMA floppy:ACSI:IDE:Falcon-SCSI", stdma_int))

Likewise.

> diff --git a/drivers/net/atarilance.c b/drivers/net/atarilance.c
> index ce0091e..1833b12 100644
> --- a/drivers/net/atarilance.c
> +++ b/drivers/net/atarilance.c
> @@ -554,7 +554,7 @@ static unsigned long __init lance_probe1( struct net_device *dev,
>  		memaddr == (unsigned short *)0xffe00000) {
>  		/* PAMs card and Riebl on ST use level 5 autovector */
>  		if (request_irq(IRQ_AUTO_5, lance_interrupt, IRQ_TYPE_PRIO,
> -		            "PAM/Riebl-ST Ethernet", dev)) {
> +		            "PAM:Riebl-ST Ethernet", dev)) {

Likewise.

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/