linux-kernel - Re: [PATCH] C2port:Fix deprecated exported interfaces c2port.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 May 2011 07:10:24 -0700
From:	Greg KH <gregkh@...e.de>
To:	Wanlong Gao <wanlong.gao@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] C2port:Fix deprecated exported interfaces c2port.h

On Thu, May 05, 2011 at 08:29:09PM +0800, Wanlong Gao wrote:
> From: Wanlong Gao <wanlong.gao@...il.com>
> 
> Change to_class_dev to to_device since the struct class_device had
> merged to struct device.
> Fix the to_c2port_device interface since the struct c2port_device
> has no member named class.
> 
> Signed-off-by: Wanlong Gao <wanlong.gao@...il.com>
> ---
>  include/linux/c2port.h |    4 ++--

I don't know why you sent this to me, have you looked at the
scripts/get_maintainer.pl tool?


>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/c2port.h b/include/linux/c2port.h
> index 2a5cd86..7e6bd33 100644
> --- a/include/linux/c2port.h
> +++ b/include/linux/c2port.h
> @@ -60,8 +60,8 @@ struct c2port_ops {
>   * Exported functions
>   */
>  
> -#define to_class_dev(obj) container_of((obj), struct class_device, kobj)
> -#define to_c2port_device(obj) container_of((obj), struct c2port_device, class)
> +#define to_device(obj) container_of(obj, struct device, kobj)
> +#define to_c2port_device(obj) container_of(obj, struct c2port_device, dev.kobj)

Doesn't this break the build?  If not, something is really wrong here.

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/