linux-kernel - Re: [PATCH 3/3] mm: change incorrect 'extern' keyword to 'static'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 May 2011 17:27:30 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	Robin Dong <hao.bigrat@...il.com>
Cc:	linux-kernel@...r.kernel.org, Robin Dong <sanbai@...bao.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 3/3] mm: change incorrect 'extern' keyword to 'static'

On Thu, May 5, 2011 at 4:51 PM, Robin Dong <hao.bigrat@...il.com> wrote:
> Change function memblock_memory_can_coalesce from 'extern' to 'static' to
> match the memblock_* series function.
>
> Signed-off-by: Robin Dong <sanbai@...bao.com>
> ---
>  mm/memblock.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 400dc62..9570c43 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -292,7 +292,7 @@ static int __init_memblock memblock_double_array(struct memblock_type *type)
>        return 0;
>  }
>
> -extern int __init_memblock __weak memblock_memory_can_coalesce(phys_addr_t addr1, phys_addr_t size1,
> +static int __init_memblock __weak memblock_memory_can_coalesce(phys_addr_t addr1, phys_addr_t size1,

I guess you will get build error as
"error: static declaration of ‘***’ follows non-static declaration".

No?

Thanks,
Yong

>                                          phys_addr_t addr2, phys_addr_t size2)
>  {
>        return 1;
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/