linux-kernel - Re: [PATCH] atomic: add *_dec_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 8 May 2011 11:33:48 +0200
From:	Sven Eckelmann <sven@...fation.org>
To:	"Russell King - ARM Linux" <linux@....linux.org.uk>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	linux-mips@...ux-mips.org, linux-m32r@...linux-m32r.org,
	linux-ia64@...r.kernel.org, linux-parisc@...r.kernel.org,
	linux-cris-kernel@...s.com, linux-s390@...r.kernel.org,
	linux-sh@...r.kernel.org, x86@...nel.org,
	Chris Metcalf <cmetcalf@...era.com>,
	David Howells <dhowells@...hat.com>,
	linux-m68k@...ts.linux-m68k.org, linux-am33-list@...hat.com,
	linux-alpha@...r.kernel.org, sparclinux@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] atomic: add *_dec_not_zero

Russell King - ARM Linux wrote:
[...]
> Do we need atomic_dec_not_zero() et.al. in every arch header - is there no
> generic header which it could be added to?

Mike Frysinger already tried to answer it in 
<BANLkTimctgbto3dsnJ3d3r7NggS0KF9_Sw@...l.gmail.com>:
> that's what asm-generic is for.  if the arch isnt using it, it's
> either because the arch needs to convert to it, or they're using SMP
> and asm-generic doesnt yet support that for atomic.h.
>
> for example, the Blackfin port only needed updating for the SMP case.
> in the non-SMP case, we're getting the def from asm-generic/atomic.h.
> -mike

Feel free to change that but I just followed the style used by all other 
macros and will not redesign the complete atomic*.h idea.

thanks,
	Sven

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)