lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 May 2011 16:21:36 +0900 From: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com> To: Paul Turner <pjt@...gle.com> CC: linux-kernel@...r.kernel.org, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Bharata B Rao <bharata@...ux.vnet.ibm.com>, Dhaval Giani <dhaval.giani@...il.com>, Balbir Singh <balbir@...ux.vnet.ibm.com>, Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>, Srivatsa Vaddagiri <vatsa@...ibm.com>, Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>, Ingo Molnar <mingo@...e.hu>, Pavel Emelyanov <xemul@...nvz.org> Subject: Re: [patch 05/15] sched: add a timer to handle CFS bandwidth refresh (2011/05/03 18:28), Paul Turner wrote: > @@ -250,6 +253,9 @@ struct cfs_bandwidth { > ktime_t period; > u64 quota; > s64 hierarchal_quota; > + > + int idle; > + struct hrtimer period_timer; > #endif > }; > "idle" is not used yet. How about adding it in later patch? Plus, comment explaining how it is used would be appreciated. > static void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) > { > raw_spin_lock_init(&cfs_b->lock); > cfs_b->quota = RUNTIME_INF; > cfs_b->period = ns_to_ktime(default_cfs_period()); > + > + hrtimer_init(&cfs_b->period_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); > + cfs_b->period_timer.function = sched_cfs_period_timer; > + > } Nit: blank line? Reviewed-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com> Thanks, H.Seto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists