linux-kernel - RE: [PATCH v6] staging: Add ST-Ericsson CG2900 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 May 2011 10:34:47 +0200
From:	Par-Gunnar HJALMDAHL <par-gunnar.p.hjalmdahl@...ricsson.com>
To:	Greg KH <greg@...ah.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
	Pavan Savoy <pavan_savoy@...y.com>,
	Vitaly Wool <vitalywool@...il.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Marcel Holtmann <marcel@...tmann.org>,
	Lukasz Rymanowski <Lukasz.Rymanowski@...to.com>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>,
	Par-Gunnar Hjalmdahl <pghatwork@...il.com>,
	Lee Jones <lee.jones@...aro.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>
Subject: RE: [PATCH v6] staging: Add ST-Ericsson CG2900 driver

> -----Original Message-----
> From: Greg KH [mailto:greg@...ah.com]
> Sent: den 10 maj 2011 22:08
> 
> {sigh}
> 
> This breaks the build again, the error messages are below :(
> 
> I'm about to give up here, so the next time you send this patch in, I
> want some kind of proof that the code will at least build properly.
> 
> How you provide this is up to you.
> 
> Oh, and if the next one breaks stuff again, you will owe me a lot of
> beer, although I think you owe me already...
> 
> thanks,
> 
> greg k-h
> 
>   CC [M]  drivers/staging/cg2900/mfd/cg2900_chip.o
> drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: error: unknown field
> ‘platform_data’ specified in initializer
> drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: warning:
> initialization makes integer from pointer without a cast
> drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: error: initializer
> element is not computable at load time
> drivers/staging/cg2900/mfd/cg2900_chip.c:2940:3: error: (near
> initialization for ‘cg2900_devs[0].id’)

Hi Greg,

What linux-next tag did you base the patch on?
I used next-20110510 and in that tag the file include/Linux/mfd/core.h
The struct mfd_cell has a parameter called platform_data, while in your
build it seems it doesn't.
This was changed very recently in the core.h file (on April 6).
So for core.h the last commit ID I have in the tag I built upon is
558aa9c0d620b91a896d5e39ce8a570bed65589b.

Thanks,
P-G