linux-kernel - Re: [PATCH] Documentation: Remove the obsolete parameters in 2 jbd2 functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 May 2011 16:56:04 +0200
From:	Jan Kara <jack@...e.cz>
To:	Tao Ma <tm@....ma>
Cc:	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	Jan Kara <jack@...e.cz>, Randy Dunlap <rdunlap@...otime.net>,
	tytso@....edu
Subject: Re: [PATCH] Documentation: Remove the obsolete parameters in 2
 jbd2 functions.

On Wed 11-05-11 22:18:41, Tao Ma wrote:
> From: Tao Ma <boyu.mt@...bao.com>
> 
> credits isn't a parameter for jbd2_journal_get_write_access and
> jbd2_journal_get_undo_access. So remove the corresponding comments.
> 
> Cc: Jan Kara <jack@...e.cz>
> Cc: Randy Dunlap <rdunlap@...otime.net>
> Signed-off-by: Tao Ma <boyu.mt@...bao.com>
  For JBD2 changes please CC also Ted Ts'o <tytso@....edu> since he is
merging JBD2 patches. The patch is fine. Thanks.

								Honza
> ---
>  fs/jbd2/transaction.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 05fa77a..0a82612 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -813,7 +813,6 @@ out:
>   * int jbd2_journal_get_write_access() - notify intent to modify a buffer for metadata (not data) update.
>   * @handle: transaction to add buffer modifications to
>   * @bh:     bh to be used for metadata writes
> - * @credits: variable that will receive credits for the buffer
>   *
>   * Returns an error code or 0 on success.
>   *
> @@ -931,7 +930,6 @@ out:
>   *     non-rewindable consequences
>   * @handle: transaction
>   * @bh: buffer to undo
> - * @credits: store the number of taken credits here (if not NULL)
>   *
>   * Sometimes there is a need to distinguish between metadata which has
>   * been committed to disk and that which has not.  The ext3fs code uses
> -- 
> 1.7.1
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/