linux-kernel - Re: [GIT PULL] fuse fix for 2.6.39

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 May 2011 08:19:30 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Miklos Szeredi <miklos@...redi.hu>,
	Al Viro <viro@...iv.linux.org.uk>,
	Christoph Hellwig <hch@....de>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Trond Myklebust <Trond.Myklebust@...app.com>
Subject: Re: [GIT PULL] fuse fix for 2.6.39

Ooh.

It's "lookup_one_len()", isn't it?

So any filesystem that uses that helper will need to be protected from
a NULL 'nd'.

And then you have nfsd, ecryptfs and cachefiles that will do it on
_other_ filesystems.

Gaah. Ugly. So either we really should fix the filesystems that don't
have protection from a NULL nd, or we should fix lookup_one_len() (are
there perhaps other cases I missed?)

Al? Christoph? Comments?

                            Linus

On Thu, May 12, 2011 at 8:12 AM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> Hmm.
>
> Do we really ever have a NULL 'nd' these days? Can you send me the
> backtrace for whatever oops that was reported?
>
> The reason I ask is because at least NFS also does just
>
>        if (nd->flags & LOOKUP_RCU)
>                return -ECHILD;
>
> in its nfs_lookup/open_revalidate() functions. As does cifs, ncpfs, p9
> and coda from a quick grep.
>
>                        Linus
>
> On Thu, May 12, 2011 at 8:04 AM, Miklos Szeredi <miklos@...redi.hu> wrote:
>>
>> Please pull from
>>
>>  git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-linus
>>
>> Miklos Szeredi (1):
>>      fuse: fix oops in revalidate when called with NULL nameidata
>>
>> ---
>>  fs/fuse/dir.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/