linux-kernel - Re: [Xen-devel] Re: [PATCH] xen block backend driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 May 2011 17:01:52 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Ian Campbell <Ian.Campbell@...citrix.com>
Cc:	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	Stefano Stabellini <Stefano.Stabellini@...citrix.com>,
	"jaxboe@...ionio.com" <jaxboe@...ionio.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"hch@...radead.org" <hch@...radead.org>
Subject: Re: [Xen-devel] Re: [PATCH] xen block backend driver.

On Wed, May 11, 2011 at 04:02:12PM +0100, Ian Campbell wrote:
> On Thu, 2011-05-05 at 19:11 +0100, Konrad Rzeszutek Wilk wrote:
> > This is the host side counterpart to the frontend driver
> > in drivers/block/xen-blkfront.c. The PV protocol is also implemented by
> > frontend drivers in other OSes too, such as the BSDs and even Windows.
> > 
> > The patch is based on the driver from the xen.git pvops kernel tree but
> > has been put through the checkpatch.pl wringer plus several manual
> > cleanup passes. It has also been moved from drivers/xen/blkback to
> > drivers/block/xen-blback.
> > 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> 
> Reviewed-by: Ian Campbell <ian.campbell@...rix.com>
> 
> Not much to say below, mostly minor nits really.

Thanks for reviewing it. I believe I've taken all your apt comments
in consideration. Will post the v3.2 shortly.

> > +/*
> > + * Function to copy the from the ring buffer the 'struct blkif_request'
> 
> Is the blkif namespace fair game? (I was asked to change netif is all)

It is shared with the frontend driver. I can definitly change it
but was thinking to do it once it is in the tree - that way it can
be one patch for both of them without having to worry about carrying
two branches for blkfront.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/