linux-kernel - Re: [PATCH v2] kconfig: autogenerated config_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 May 2011 12:01:52 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
Cc:	Michal Marek <mmarek@...e.cz>, Arnaud Lacombe <lacombar@...il.com>,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	x86@...nel.org, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v2] kconfig: autogenerated config_is_xxx macro


* Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com> wrote:

> On 10:30 Fri 13 May     , Ingo Molnar wrote:
> > 
> > * Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com> wrote:
> > 
> > > -#ifdef CONFIG_PCI_BIOS
> > > -	if (!rt->signature) {
> > > +	if (config_is_pci_bios() && !rt->signature) {
> > 
> > Makes sense - but please name it in a more obvious way, such as:
> > 
> > 	pci_bios_enabled()
> the idea to generate the macro via Kconfig

Okay, and there we are stuck with whatever the Kconfig name is. (we could 
rename that but not needed really)

Why not the canonical config_pci_bios() variant? It's the shortest one to 
write. The '_is' looks pretty superfluous to me.

Hm, i guess it could be mixed up with a function that configures the pci_bios.

I guess since i don't have any better idea config_is_pci_bios() sounds like a 
good choice after all.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/