linux-kernel - Re: [PATCH 3/3] checkpatch.pl: Add check for current->comm references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 May 2011 13:02:56 +0200
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"John Stultz" <john.stultz@...aro.org>,
	"Jiri Slaby" <jirislaby@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, "Ted Ts'o" <tytso@....edu>,
	"KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com>,
	"David Rientjes" <rientjes@...gle.com>,
	"Dave Hansen" <dave@...ux.vnet.ibm.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>, linux-mm@...ck.org
Subject: Re: [PATCH 3/3] checkpatch.pl: Add check for current->comm references

> On 05/13/2011 01:02 AM, John Stultz wrote:
>> @@ -2868,6 +2868,10 @@ sub process {
>>  			WARN("usage of NR_CPUS is often wrong - consider using  
>> cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" .  
>> $herecurr);
>>  		}
>>
>> +# check for current->comm usage
>> +		if ($line =~ /current->comm/) {

On Fri, 13 May 2011 08:33:39 +0200, Jiri Slaby wrote:
> This should be something like \b(current|task|tsk|t)->comm\b to catch
> also non-current comm accesses...

Or \b(?:current|task|tsk|t)\s*->\s*comm\b.

>> +			WARN("comm access needs to be protected. Use get_task_comm, or  
>> printk's \%ptc formatting.\n" . $herecurr);
>> +		}

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@...gle.com>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/