linux-kernel - Re: [PATCH] PC8736X: Correct dev_dbg() message showing major number.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 May 2011 13:41:55 -0600
From:	Jim Cromie <jim.cromie@...il.com>
To:	"Robert P. J. Day" <rpjday@...shcourse.ca>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PC8736X: Correct dev_dbg() message showing major number.

On Wed, May 4, 2011 at 3:26 AM, Robert P. J. Day <rpjday@...shcourse.ca> wrote:
>
> Currently, the debugging info is incorrect, as a successful call to
> either register_chrdev_region() or alloc_chrdev_region() returns
> simply zero, which appears to be what the following code would print.
> Skip the checking, just print the value of "major", which should be
> correct.
>
> Signed-off-by: Robert P. J. Day <rpjday@...shcourse.ca>
>
> ---

NAK.  'dynamic' is not always correct

> +       dev_dbg(&pdev->dev, "got dynamic major %d\n", major);

Ive got patches to replace register|alloc _chrdev_region
which may require merge conflict resolution.
Id prefer to hold off til theyre reviewed, accepted.

Actually, shouldnt conflict - rc<0 code is in between.
If you want to rework it, I'll ack it.

thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/