linux-kernel - Re: [alsa-devel] [PATCH RFC] radio-sf16fmr2: convert to generic TEA575x interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 May 2011 12:01:12 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Ondrej Zary <linux@...nbow-software.org>
Cc:	linux-media@...r.kernel.org, alsa-devel@...a-project.org,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH RFC] radio-sf16fmr2: convert to generic TEA575x	interface

At Sat, 14 May 2011 00:17:23 +0200,
Ondrej Zary wrote:
> 
> Hello,
> the SF16-FMR2 radio card is basically a TEA5757 tuner connected to ISA bus but
> the driver currently uses its own implementation. I converted the driver to
> use generic tea575x-tuner implementation (see patch below) and it works fine.
> 
> But the tea575x-tuner module is located in /sound/i2c/other and the
> corresponding Kconfig in /sound/pci. Should it be moved
> to /drivers/media/radio or better leave it as is?

That would be a feasible option.
Actually no ALSA-specific data / function is used in tea575x-tuner.c,
so it'd be more natural to put it to drivers/media/radio.
(And remove the inclusion of <sound/*> from relevant files.)


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/