| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 May 2011 23:26:33 +0200 From: Hans Verkuil <hverkuil@...all.nl> To: Ondrej Zary <linux@...nbow-software.org> Cc: linux-media@...r.kernel.org, alsa-devel@...a-project.org, "Kernel development list" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH RFC v2] radio-sf16fmr2: convert to generic TEA575x interface On Sunday, May 15, 2011 22:18:21 Ondrej Zary wrote: > Thanks, it's much simpler with the new control framework. > Do the negative volume control values make sense? The TC9154A chip can > attenuate the volume from 0 to -68dB in 2dB steps. It does make sense, but I think I would offset the values so they start at 0. Mostly because there might be some old apps that set the volume to 0 when they want to mute, which in this case is full volume. I am not aware of any driver where a volume of 0 isn't the same as the lowest volume possible, so in this particular case I would apply an offset. I will have to do a closer review tomorrow or the day after. I think there are a few subtleties that I need to look at. Ping me if you haven't heard from me by Wednesday. I would really like to get these drivers up to spec now that I have someone who can test them, and once that's done I hope that I never have to look at them again :-) (Unlikely, but one can dream...) Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists