linux-kernel - Re: [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 May 2011 11:58:50 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Mohan Pallaka <mpallaka@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.intradead.org, linux-input@...r.kernel.org,
	linux-i2c@...r.kernel.org
Subject: Re: [PATCH 1/2] pwm: Add __weak attributed functions for pwm
	operations

On Sun, May 15, 2011 at 01:00:31AM -0700, Dmitry Torokhov wrote:
> On Fri, May 13, 2011 at 06:13:21PM +0530, Mohan Pallaka wrote:
> > For chip drivers that support both pwm and non-pwm modes
> > would encounter compilation errors if the platform doesn't
> > have support for pwm though the chip is programmed to work
> > in non-pwm mode. Add __weak attributed pwm functions to avoid
> > compilation issues in these scenarios.
> > 
> 
> Russell,
> 
> You seem to have authored pwm.h, do you have any objections to this
> change?

This seems to be a recipe for an oops.  Have a look at how
linux/regulator/consumer.h deals with this kind of problem, and notice
that we have CONFIG_HAVE_PWM to indicate whether this interface is
supported or not.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/