linux-kernel - RE: [PATCH 2/2] Connector: Correctly set the error code in case of success when dispatching receive callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 May 2011 22:53:18 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Greg KH <greg@...ah.com>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>
Subject: RE: [PATCH 2/2] Connector: Correctly set the error code in case of
 success when dispatching receive callbacks



> -----Original Message-----
> From: Greg KH [mailto:greg@...ah.com]
> Sent: Tuesday, May 17, 2011 6:32 PM
> To: KY Srinivasan
> Cc: gregkh@...e.de; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; virtualization@...ts.osdl.org
> Subject: Re: [PATCH 2/2] Connector: Correctly set the error code in case of
> success when dispatching receive callbacks
> 
> On Tue, May 17, 2011 at 03:25:38PM -0700, K. Y. Srinivasan wrote:
> > The recent changes to the connector code introduced this bug where even
> > when a callback was invoked, we would return an error resulting in
> > double freeing of the skb. This patch fixes this bug.
> 
> By "recent" what do you mean?  Is this something that is in the .39
> kernel?  Do you have a git commit id that caused this?
> 
> Or is this due to changes that are queued up for the .40 merge window?

I just happened to test KVP functionality yesterday on latest bits from your tree (NEXT)
and discovered that whenever  something was sent to the kernel from userland on a 
connector channel, the system would hang. The following commit appears to be where
this bug was introduced:

commit 04f482faf50535229a5a5c8d629cf963899f857c
Author: Patrick McHardy <kaber@...sh.net>
Date:   Mon Mar 28 08:39:36 2011 +0000

Since prior to this commit I don't see this problem. In any event the current code is clearly
broken.

Regards,

K. Y

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/