linux-kernel - Re: [PATCH -next] ata: PATA_ARASAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 May 2011 09:05:07 +0530
From:	viresh kumar <viresh.kumar@...com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
	Jeff Garzik <jgarzik@...ox.com>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] ata: PATA_ARASAN_CF depends on DMADEVICES

On 05/23/2011 06:02 AM, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix kconfig unmet dependency warning:
> 
> warning: (PATA_ARASAN_CF && VIDEO_TIMBERDALE && SND_SOC_SH4_SIU) selects DMA_ENGINE which has unmet direct dependencies (DMADEVICES)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Viresh Kumar <viresh.kumar@...com>
> ---
>  drivers/ata/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20110520.orig/drivers/ata/Kconfig
> +++ linux-next-20110520/drivers/ata/Kconfig
> @@ -313,6 +313,7 @@ config PATA_AMD
>  
>  config PATA_ARASAN_CF
>  	tristate "ARASAN CompactFlash PATA Controller Support"
> +	depends on DMADEVICES
>  	select DMA_ENGINE

Randy,

I think we can also remove this "select DMA_ENGINE" line.

Otherwise, it looks fine.

Acked-by: Viresh Kumar <viresh.kumar@...com>

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/