linux-kernel - question about blk_schedule_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 May 2011 17:05:19 +1000
From:	Con Kolivas <kernel@...ivas.org>
To:	linux-kernel@...r.kernel.org
Cc:	axboe@...nel.dk, mingo@...e.hu, peterz@...radead.org
Subject: question about blk_schedule_flush_plug

I was looking at the scheduler changes going into 2.6.39 again and wondered 
about the use of blk_schedule_flush_plug smack in the middle of schedule()

It looks like this:
			if (blk_needs_flush_plug(prev)) {
				raw_spin_unlock(&rq->lock);
				blk_schedule_flush_plug(prev);
				raw_spin_lock(&rq->lock);
			}

Now call me suspicious but to my eyes it looks really dubious unlocking the 
runqueue like that right in the heart of schedule().

Comments?

Thanks,
Con
-- 
-ck
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/