linux-kernel - Re: [GIT PULL] more x86/apic changes for v2.6.40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 May 2011 08:15:25 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Daniel J Blueman <daniel.blueman@...il.com>
Subject: Re: [GIT PULL] more x86/apic changes for v2.6.40


* Ingo Molnar <mingo@...e.hu> wrote:

> Possibly the resume fix in the APIC merge :-/
> 
> It's these commits:
> 
>  31dce14a3269: x86, ioapic: Use ioapic_saved_data while enabling intr-remapping
>  4c79185cdb14: x86, ioapic: Allocate ioapic_saved_data early
>  b64ce24daffb: x86, ioapic: Fix potential resume deadlock
> 
> The first one fixes the resume bug in an easily backportable way (although 
> the GFP_ATOMIC is not nice), the later two do it cleaner.
> 
> So if b64ce24daffb works for you and 31dce14a3269 breaks this would signal 
> that the fix from Suresh is the source of the Atom regression.

In particular the lapic_resume() bit looks suspect. Does save_ioapic_entries() 
get called? It's called in enable_IR_x2apic() but your Atom is probably not 
x2apic. Non-x2apic system do not get save_ioapic_entries() called, so there's 
nothing to restore at resume time AFAICS ... Suresh?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/