| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 May 2011 13:12:31 -0400 From: Mike Frysinger <vapier@...too.org> To: Tanya Brokhman <tlinder@...eaurora.org> Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>, greg@...ah.com, linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org, balbi@...com, ablay@...eaurora.org, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v12 4/8] usb:gadget: Add SuperSpeed support to the Gadget Framework On Tue, May 24, 2011 at 01:37, Tanya Brokhman wrote: >> > Mike answered that you're right in your observation. I'm not familiar >> > with blackfin. Could you please elaborate on this? I understand that >> > I need to use put_unaligned_le16(), will do, but I would like to better >> > understand why and if there is a way to test this so that blackfin >> > won't be broken. >> >> not all arches support unaligned accesses. or they do, but it's done >> via (non-trivial) exception processing in software. req->buf is of >> type void* and so presumably is not guaranteed to be aligned on a 2 >> byte boundary. > > Thanks for the explanation, Mike! I'll update the patch. also, for arches where unaligned accesses work (like x86), the unaligned macros will simply expand to direct accesses like the code you had originally. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists