linux-kernel - Re: [PATCH 3/4] cfq-iosched: remove unused 'group_changed' in cfq_service_tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 May 2011 10:32:06 -0700
From:	Justin TerAvest <teravest@...gle.com>
To:	Namhyung Kim <namhyung@...il.com>
Cc:	Jens Axboe <axboe@...nel.dk>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] cfq-iosched: remove unused 'group_changed' in cfq_service_tree_add()

Looks good to me.

Reviewed-by: Justin TerAvest <teravest@...gle.com>

On Mon, May 23, 2011 at 8:18 PM, Namhyung Kim <namhyung@...il.com> wrote:
> The 'group_changed' variable is initialized to 0 and never changed, so
> checking the variable is meaningless.
>
> It is a leftover from 0bbfeb832042 ("cfq-iosched: Always provide group
> iosolation."). Let's get rid of it.
>
> Signed-off-by: Namhyung Kim <namhyung@...il.com>
> Cc: Justin TerAvest <teravest@...gle.com>
> ---
>  block/cfq-iosched.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
> index a79e62063144..4ceebd346710 100644
> --- a/block/cfq-iosched.c
> +++ b/block/cfq-iosched.c
> @@ -1206,7 +1206,6 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq,
>        struct cfq_rb_root *service_tree;
>        int left;
>        int new_cfqq = 1;
> -       int group_changed = 0;
>
>        service_tree = service_tree_for(cfqq->cfqg, cfqq_prio(cfqq),
>                                                cfqq_type(cfqq));
> @@ -1277,7 +1276,7 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq,
>        rb_link_node(&cfqq->rb_node, parent, p);
>        rb_insert_color(&cfqq->rb_node, &service_tree->rb);
>        service_tree->count++;
> -       if ((add_front || !new_cfqq) && !group_changed)
> +       if (add_front || !new_cfqq)
>                return;
>        cfq_group_notify_queue_add(cfqd, cfqq->cfqg);
>  }
> --
> 1.7.5.2
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/