linux-kernel - RE: [PATCH v12 4/8] usb:gadget: Add SuperSpeed support to the Gadget Framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 May 2011 08:10:23 +0300
From:	"Tanya Brokhman" <tlinder@...eaurora.org>
To:	"'Sebastian Andrzej Siewior'" <bigeasy@...utronix.de>,
	"'Mike Frysinger'" <vapier@...too.org>
Cc:	<greg@...ah.com>, <linux-usb@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>, <balbi@...com>,
	<ablay@...eaurora.org>,
	"'open list'" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v12 4/8] usb:gadget: Add SuperSpeed support to the Gadget Framework

Hi Sebastian,

> >+	case USB_REQ_GET_STATUS:
> >+		if (!gadget_is_superspeed(gadget))
> >+			goto unknown;
> >+		if (ctrl->bRequestType != (USB_DIR_IN |
> USB_RECIP_INTERFACE))
> >+			goto unknown;
> >+		value = 2;	/* This is the length of the get_status
reply
> */
> >+		*((__le16 *)req->buf) = 0;
> 
> Mike please correct me if I'm wrong bug this looks like a case for
> put_unaligned_le16().
> Is someone actually using gadget support on blackfin? I'm asking
> because
> config_buf() (same file, upstream) is using req->buf to build the
> descriptors in place and one element is le16 which should be affected.
> 

Mike answered that you're right in your observation. I'm not familiar with
blackfin. Could you please elaborate on this? I understand that I need to
use put_unaligned_le16(), will do, but I would like to better understand why
and if there is a way to test this so that blackfin won't be broken.

Best regards,
Tanya Brokhman
Consultant for Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/