linux-kernel - Re: [PATCH] viafb: use display information in info not in var for panning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 25 May 2011 11:41:59 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Florian Tobias Schandinat <FlorianSchandinat@....de>
Cc:	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...nel.org
Subject: Re: [PATCH] viafb: use display information in info not in var for panning

Hi Florian,

On Tuesday 24 May 2011 00:07:26 Florian Tobias Schandinat wrote:
> As Laurent pointed out we must not use any information in the passed
> var besides xoffset, yoffset and vmode as otherwise applications
> might abuse it. Also use the aligned fix.line_length and not the
> (possible) unaligned xres_virtual.
> 
> Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@....de>
> Reported-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Cc: stable@...nel.org

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/video/via/viafbdev.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/via/viafbdev.c b/drivers/video/via/viafbdev.c
> index 3114a87..aa87529 100644
> --- a/drivers/video/via/viafbdev.c
> +++ b/drivers/video/via/viafbdev.c
> @@ -348,8 +348,9 @@ static int viafb_pan_display(struct fb_var_screeninfo
> *var, struct fb_info *info)
>  {
>  	struct viafb_par *viapar = info->par;
> -	u32 vram_addr = (var->yoffset * var->xres_virtual + var->xoffset)
> -		* (var->bits_per_pixel / 8) + viapar->vram_addr;
> +	u32 vram_addr = viapar->vram_addr
> +		+ var->yoffset * info->fix.line_length
> +		+ var->xoffset * info->var.bits_per_pixel / 8;
> 
>  	DEBUG_MSG(KERN_DEBUG "viafb_pan_display, address = %d\n", vram_addr);
>  	if (!viafb_dual_fb) {

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/