linux-kernel - Re: early kernel crash when kmemleak is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 May 2011 22:37:54 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
cc:	Catalin Marinas <catalin.marinas@....com>,
	Tejun Heo <tj@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	Dipankar Sarma <dipankar@...ibm.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: early kernel crash when kmemleak is enabled

On Fri, 27 May 2011, Marcin Slusarz wrote:
> On Thu, May 19, 2011 at 03:08:53PM +0100, Catalin Marinas wrote:
> > On Thu, 2011-05-19 at 14:54 +0100, Tejun Heo wrote:
> > > On Thu, May 19, 2011 at 02:48:44PM +0100, Catalin Marinas wrote:
> > > > Thanks for tracking this down. Untested (I can add a log afterwards):
> > > >
> > > > diff --git a/init/main.c b/init/main.c
> > > > index 4a9479e..48df882 100644
> > > > --- a/init/main.c
> > > > +++ b/init/main.c
> > > > @@ -580,8 +580,8 @@ asmlinkage void __init start_kernel(void)
> > > >  #endif
> > > >       page_cgroup_init();
> > > >       enable_debug_pagealloc();
> > > > -     kmemleak_init();
> > > >       debug_objects_mem_init();
> > > > +     kmemleak_init();
> > > >       setup_per_cpu_pageset();
> > > >       numa_policy_init();
> > > >       if (late_time_init)
> > > 
> > > Heh, that was swift.  Yeap, seems to work here.  Please feel free to
> > > add my Tested-by.
> > 
> > Thanks. I have two other minor kmemleak fixes, so I'll send Linus a pull
> > request in the next day or so.
> > 
> 
> With this patch applied kernel didn't panic, but kmemleak did not work either:
> 
> kmemleak: Early log buffer exceeded, please increase DEBUG_KMEMLEAK_EARLY_LOG_SIZE
> kmemleak: Kernel memory leak detector disabled
> 
> I increased DEBUG_KMEMLEAK_EARLY_LOG_SIZE from 400 to 1000, and it crashed in
> exactly the same way:

...
 
> The problem is: debugobjects want to use workqueues (system_wq actually), but they
> are initialized much later in a boot process.
> 
> Attached patch fixes this issue for me.
> 
> 
> diff --git a/lib/debugobjects.c b/lib/debugobjects.c
> index 9d86e45..a78b7c6 100644
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
> @@ -198,7 +198,7 @@ static void free_object(struct debug_obj *obj)
>  	 * initialized:
>  	 */
>  	if (obj_pool_free > ODEBUG_POOL_SIZE && obj_cache)
> -		sched = !work_pending(&debug_obj_work);
> +		sched = keventd_up() && !work_pending(&debug_obj_work);
>  	hlist_add_head(&obj->node, &obj_pool);
>  	obj_pool_free++;
>  	obj_pool_used--;
> 

Sigh, yes. Care to resend with changelog and signed-off-by ?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/