linux-kernel - RE: sata_mv port lockup on hotplug (kernel 2.6.38.2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 May 2011 14:07:31 +0100
From:	Bruce Stenning <b.stenning@...igovision.com>
To:	Mark Lord <kernel@...savvy.com>
CC:	Tejun Heo <htejun@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>
Subject: RE: sata_mv port lockup on hotplug (kernel 2.6.38.2)

> > Mark, did you get a chance to clean up the sata_mv spinlock addition in
> > mv_set_main_irq_mask?
>
> Not yet.  I've been waiting to hear back from you as to
> whether they visibly fix anything or not.

Having now tested with Tejun's two patches and without the spinlock in
mv_set_main_irq_mask for a reasonable time, the hotplug seems to be very
reliable.  So I think it's probably best to leave the spinlock out and
continue to observe the behaviour with further testing.

Thanks,
Bruce.

Latest News at: http://www.indigovision.com/index.php/en/news.html