linux-kernel - Re: Kernel OOPS in function_graph_tracer due to the 44259b1abfaa8bb819d25d41d71e8e33e25dd36a commit (x86-64: Move vread_tsc into a new file with sensible options)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 May 2011 00:19:08 +0200
From:	"Witold Baryluk" <baryluk@....if.uj.edu.pl>
To:	Andrew Lutomirski <luto@....edu>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Andi Kleen <andi@...stfloor.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	John Stultz <johnstul@...ibm.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: Kernel OOPS in function_graph_tracer due to the
 44259b1abfaa8bb819d25d41d71e8e33e25dd36a commit (x86-64: Move vread_tsc
 into a new file with sensible options)

On 05-30 16:14, Andrew Lutomirski wrote:
> On Mon, May 30, 2011 at 12:10 PM, Witold Baryluk
> <baryluk@....if.uj.edu.pl> wrote:
> > Hi,
> >
> > I found yesterday a problem when booting system on Pentium-M, 32-bit.
> >
> > I got approximetly this
> >
> > [    2.459170] Testing tracer function_graph:
> > [    2.466979] BUG: unable to handle kernel paging request at e421cc10
> 
> >
> > Reverting commit 44259b1abfaa8bb819d25d41d71e8e33e25dd36a on top of current
> > kernel make bug disapear.
> >
> > Disabling CONFIG_FUNCTION_GRAPH_TRACER also make bug dispear.
> >
> 
> Of course, the most trivial of my patches was the one with the most
> significant bug.  Can you try this fix:
> 
> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commitdiff;h=89e1be50c68eb5e58b873dce87bbac627ee18d1f
> 
> --Andy

Fix works. :)

Compiled with patch and CONFIG_FUNCTION_GRAPH_TRACER enabled, and
booted 4 times without problem

[    6.611505] Testing dynamic ftrace ops #1: 
[    6.771532] Refined TSC clocksource calibration: 3199.859 MHz.
[    6.772337] Switching to clocksource tsc
[    6.919805] (1 0 1 1 0) (1 1 2 1 0) (2 1 3 1 215146) (2 2 4 1 215428) PASSED
[    7.058209] Testing dynamic ftrace ops #2: (1 0 1 213422 0) (1 1 2 213704 0) (2 1 3 1 184) (2 2 4 270 453) PASSED
[    7.646890] Testing tracer irqsoff: PASSED
[    7.754403] Testing tracer preemptoff: PASSED
[    7.860605] Testing tracer preemptirqsoff: PASSED
[    7.970927] Testing tracer wakeup: PASSED
[    8.363620] Testing tracer wakeup_rt: PASSED
[    8.763273] Testing tracer function_graph: PASSED
[    9.052030] HugeTLB registered 2 MB page size, pre-allocated 0 pages
[    9.061322] VFS: Disk quotas dquot_6.5.2
[    9.065226] Dquot-cache hash table entries: 1024 (order 0, 4096 bytes)
[    9.095324] Registering the id_resolver key type
[    9.097664] FS-Cache: Netfs 'nfs' registered for caching
[    9.103503] nfs4filelayout_init: NFSv4 File Layout Driver Registering...
[    9.111907] fuse init (API version 7.16)
[    9.116706] msgmni has been set to 207
[    9.143692] cryptomgr_test used greatest stack depth: 6452 bytes left
[    9.163685] alg: No test for fcrypt (fcrypt-generic)
[    9.205037] alg: No test for stdrng (krng)
[    9.452480] NET: Registered protocol family 38
[    9.456719] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 253)
[    9.458912] io scheduler noop registered
[    9.459136] io scheduler deadline registered (default)
[    9.459822] io scheduler cfq registered
[    9.460551] start plist test
[    9.465413] end plist test



Thanks you.

I forgot to check linux-tip/next.

Good work, hope it will land quickly in Linus' tree.


-- 
Witold Baryluk

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)