linux-kernel - Re: [PATCH] leds: fix the menuconfig being wrongly displayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Jun 2011 08:57:09 -0400
From:	Valdis.Kletnieks@...edu
To:	Eric Miao <eric.y.miao@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Eric Miao <eric.miao@...aro.org>,
	Eric Miao <eric.miao@...onical.com>,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH] leds: fix the menuconfig being wrongly displayed

On Thu, 02 Jun 2011 13:09:14 +0800, Eric Miao said:
> From: Eric Miao <eric.miao@...onical.com>
> 
> Seems when a config option does not have a dependency of the menuconfig,
> it messes the display of the rest configs, even if it's a hidden one.
> 
> Signed-off-by: Eric Miao <eric.y.miao@...il.com>
> Cc: Richard Purdie <rpurdie@...ys.net>
> ---
>  drivers/leds/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 23f0d5e..7066820 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -7,6 +7,8 @@ menuconfig NEW_LEDS
>  	  This is not related to standard keyboard LEDs which are controlled
>  	  via the input system.
>  
> +if NEW_LEDS
> +
>  config LEDS_CLASS
>  	bool "LED Class Support"
>  	depends on NEW_LEDS

Having added that 'if', do we still need that 'depends'?

Content of type "application/pgp-signature" skipped