linux-kernel - Re: [PATCH] fix return values of rpcb_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 05 Jun 2011 15:06:50 +0200
From:	Andreas Schwab <schwab@...ux-m68k.org>
To:	Al Viro 
	<public-viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@...ne.gmane.org>
Cc:	public-linux-nfs-u79uwXL29TY76Z2rM5mHXA@...ne.gmane.org,
	Chuck Lever 
	<public-chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@...ne.gmane.org>,
	public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@...ne.gmane.org
Subject: Re: [PATCH] fix return values of rpcb_create_local()



Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@...lic.gmane.org> writes:

> diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
> index 9a80a92..5efaf5f 100644
> --- a/net/sunrpc/rpcb_clnt.c
> +++ b/net/sunrpc/rpcb_clnt.c
> @@ -193,7 +193,7 @@ static int rpcb_create_local_unix(void)
>  	if (IS_ERR(clnt)) {
>  		dprintk("RPC:       failed to create AF_LOCAL rpcbind "
>  				"client (errno %ld).\n", PTR_ERR(clnt));
> -		result = -PTR_ERR(clnt);
> +		result = PTR_ERR(clnt);
>  		goto out;
>  	}
>  
> @@ -242,7 +242,7 @@ static int rpcb_create_local_net(void)
>  	if (IS_ERR(clnt)) {
>  		dprintk("RPC:       failed to create local rpcbind "
>  				"client (errno %ld).\n", PTR_ERR(clnt));
> -		result = -PTR_ERR(clnt);
> +		result = PTR_ERR(clnt);

Proabably the dprintk argument should be negated as well.

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/