linux-kernel - Re: [PATCH] dma: at_hdmac.c: use resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2011 13:45:00 +0530
From:	"Koul, Vinod" <vinod.koul@...el.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	dan.j.williams@...el.com
Subject: Re: [PATCH] dma: at_hdmac.c: use resource_size

On Wed, 2011-06-01 at 15:16 -0700, H Hartley Sweeten wrote:
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Vinod Koul <vinod.koul@...el.com>
> 
> ---
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 36144f8..6a483ea 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -1216,7 +1216,7 @@ static int __init at_dma_probe(struct platform_device *pdev)
>  	atdma->dma_common.cap_mask = pdata->cap_mask;
>  	atdma->all_chan_mask = (1 << pdata->nr_channels) - 1;
>  
> -	size = io->end - io->start + 1;
> +	size = resource_size(io);
>  	if (!request_mem_region(io->start, size, pdev->dev.driver->name)) {
>  		err = -EBUSY;
>  		goto err_kfree;
> @@ -1362,7 +1362,7 @@ static int __exit at_dma_remove(struct platform_device *pdev)
>  	atdma->regs = NULL;
>  
>  	io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	release_mem_region(io->start, io->end - io->start + 1);
> +	release_mem_region(io->start, resource_size(io));
>  
>  	kfree(atdma);
>  
Applied, Thanks

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/