linux-kernel - Re: [PATCH v14 4/9] usb: Add max_speed to usb_composite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2011 14:17:57 +0300
From:	Felipe Balbi <balbi@...com>
To:	Tatyana Brokhman <tlinder@...eaurora.org>
Cc:	greg@...ah.com, linux-usb@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, balbi@...com, ablay@...eaurora.org,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v14 4/9] usb: Add max_speed to usb_composite_driver
 structure

Hi,

On Tue, May 31, 2011 at 04:18:24PM +0300, Tatyana Brokhman wrote:
> This field is used by the Gadget drivers to specify the maximum speed
> they support, meaning: the maximum speed they can provide descriptors for.
> 
> The driver speed will be set in consideration of this value.
> 
> Signed-off-by: Tatyana Brokhman <tlinder@...eaurora.org>

personally, I don't think this is good enough. The gadget speed is
actually the min() of the f_* speeds. So, IMHO this should be coming
from f_* and during bind you would:

gadget->speed = min(f->speed, gadget->speed);

for all functions. Also, both this patch and what I described above,
only works considering nobody touches that enum, so we might want to be
careful and add some comments to the enum to avoid anyone from touching
that :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)