linux-kernel - Re: [PATCH] lmLogOpen() broken failure exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2011 08:42:12 -0500
From:	Dave Kleikamp <dave.kleikamp@...cle.com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lmLogOpen() broken failure exit

Thanks, Al

On 06/05/2011 01:22 PM, Al Viro wrote:
> Callers of lmLogOpen() expect it to return -E... on failure exits, which
> is what it returns, except for the case of blkdev_get_by_dev() failure.
> It that case lmLogOpen() return the error with the wrong sign...
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
Acked-by: Dave Kleikamp <dave.kleikamp@...cle.com>

> ---
> diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
> index 278e3fb..583636f 100644
> --- a/fs/jfs/jfs_logmgr.c
> +++ b/fs/jfs/jfs_logmgr.c
> @@ -1123,7 +1123,7 @@ int lmLogOpen(struct super_block *sb)
>  	bdev = blkdev_get_by_dev(sbi->logdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
>  				 log);
>  	if (IS_ERR(bdev)) {
> -		rc = -PTR_ERR(bdev);
> +		rc = PTR_ERR(bdev);
>  		goto free;
>  	}
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/