linux-kernel - checkpatch gives false positives for include/trace/events/*.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2011 09:56:01 -0400
From:	"Theodore Ts'o" <tytso@....edu>
To:	Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: checkpatch gives false positives for include/trace/events/*.h

The format used for trace/events/*.h files makes checkpatch very
unhappy.

Fortunately the trivial patch brigade haven't (yet) started sending
pointless patches to fix checkpatch "errors".

						- Ted

ERROR: space prohibited after that open parenthesis '('
#64: FILE: include/trace/events/ext4.h:29:
+		__field(	__u64, blocks			)

ERROR: space prohibited before that close parenthesis ')'
#64: FILE: include/trace/events/ext4.h:29:
+		__field(	__u64, blocks			)

ERROR: space prohibited after that open parenthesis '('
#224: FILE: include/trace/events/ext4.h:649:
+		__field(	__u32,  logical			)

ERROR: space prohibited before that close parenthesis ')'
#224: FILE: include/trace/events/ext4.h:649:
+		__field(	__u32,  logical			)

ERROR: space prohibited after that open parenthesis '('
#225: FILE: include/trace/events/ext4.h:650:
+		__field(	__u32,	lleft			)

ERROR: space prohibited before that close parenthesis ')'
#225: FILE: include/trace/events/ext4.h:650:
+		__field(	__u32,	lleft			)

ERROR: space prohibited after that open parenthesis '('
#226: FILE: include/trace/events/ext4.h:651:
+		__field(	__u32,	lright			)

ERROR: space prohibited before that close parenthesis ')'
#226: FILE: include/trace/events/ext4.h:651:
+		__field(	__u32,	lright			)

ERROR: space prohibited after that open parenthesis '('
#262: FILE: include/trace/events/ext4.h:690:
+		__field(	__u32,  logical			)

ERROR: space prohibited before that close parenthesis ')'
#262: FILE: include/trace/events/ext4.h:690:
+		__field(	__u32,  logical			)

ERROR: space prohibited after that open parenthesis '('
#263: FILE: include/trace/events/ext4.h:691:
+		__field(	__u32,	lleft			)

ERROR: space prohibited before that close parenthesis ')'
#263: FILE: include/trace/events/ext4.h:691:
+		__field(	__u32,	lleft			)

ERROR: space prohibited after that open parenthesis '('
#264: FILE: include/trace/events/ext4.h:692:
+		__field(	__u32,	lright			)

ERROR: space prohibited before that close parenthesis ')'
#264: FILE: include/trace/events/ext4.h:692:
+		__field(	__u32,	lright			)

ERROR: space prohibited after that open parenthesis '('
#300: FILE: include/trace/events/ext4.h:730:
+		__field(	umode_t, mode			)

ERROR: space prohibited before that close parenthesis ')'
#300: FILE: include/trace/events/ext4.h:730:
+		__field(	umode_t, mode			)

ERROR: space prohibited after that open parenthesis '('
#304: FILE: include/trace/events/ext4.h:733:
+		__field(	int,	flags			)

ERROR: space prohibited before that close parenthesis ')'
#304: FILE: include/trace/events/ext4.h:733:
+		__field(	int,	flags			)

ERROR: space prohibited after that open parenthesis '('
#420: FILE: include/trace/events/ext4.h:1288:
+		__field(	unsigned int,	blocks		)

ERROR: space prohibited before that close parenthesis ')'
#420: FILE: include/trace/events/ext4.h:1288:
+		__field(	unsigned int,	blocks		)

ERROR: space prohibited after that open parenthesis '('
#460: FILE: include/trace/events/ext4.h:1363:
+		__field(	__u64,		blocks		)

ERROR: space prohibited before that close parenthesis ')'
#460: FILE: include/trace/events/ext4.h:1363:
+		__field(	__u64,		blocks		)

ERROR: space prohibited after that open parenthesis '('
#491: FILE: include/trace/events/ext4.h:1401:
+		__field(	unsigned int,	len		)

ERROR: space prohibited before that close parenthesis ')'
#491: FILE: include/trace/events/ext4.h:1401:
+		__field(	unsigned int,	len		)

ERROR: space prohibited after that open parenthesis '('
#492: FILE: include/trace/events/ext4.h:1402:
+		__field(	unsigned int,	flags		)

ERROR: space prohibited before that close parenthesis ')'
#492: FILE: include/trace/events/ext4.h:1402:
+		__field(	unsigned int,	flags		)

ERROR: space prohibited after that open parenthesis '('
#519: FILE: include/trace/events/ext4.h:1444:
+		__field(	unsigned int,	len		)

ERROR: space prohibited before that close parenthesis ')'
#519: FILE: include/trace/events/ext4.h:1444:
+		__field(	unsigned int,	len		)

total: 28 errors, 0 warnings, 468 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/