linux-kernel - Re: [PATCH] iscsi_ibft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2011 10:06:59 -0400
From:	Peter Jones <pjones@...hat.com>
To:	Connor Hansen <cmdkhh@...il.com>
CC:	konrad@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iscsi_ibft_find unused variable i

On 06/05/2011 06:35 AM, Connor Hansen wrote:
> int i is only needed if CONFIG_ACPI is set
> so move it within ifdef so kernels without ACPI
> dont allocate space for nothing. Fixes warning too.
> 
> Signed-off-by: Connor Hansen <cmdkhh@...il.com>

Reasonable enough.

Signed-off-by: Peter Jones <pjones@...hat.com>

> ---
>  drivers/firmware/iscsi_ibft_find.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/firmware/iscsi_ibft_find.c b/drivers/firmware/iscsi_ibft_find.c
> index f032e44..c2bfa50 100644
> --- a/drivers/firmware/iscsi_ibft_find.c
> +++ b/drivers/firmware/iscsi_ibft_find.c
> @@ -108,10 +108,10 @@ done:
>   */
>  unsigned long __init find_ibft_region(unsigned long *sizep)
>  {
> -	int i;
>  	ibft_addr = NULL;
>  
>  #ifdef CONFIG_ACPI
> +	int i;
>  	for (i = 0; i < ARRAY_SIZE(ibft_signs) && !ibft_addr; i++)
>  		acpi_table_parse(ibft_signs[i].sign, acpi_find_ibft);
>  #endif /* CONFIG_ACPI */


-- 
        Peter

Space, is big. Really big. You just won't believe how vastly hugely
mindbogglingly big it is. I mean you may think it's a long way down the
road to the chemist, but that's just peanuts to space.
		-- The Hitchhiker's Guide to the Galaxy

01234567890123456789012345678901234567890123456789012345678901234567890123456789
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/