linux-kernel - Re: [PATCH 3/5] CFQ: rename ioc_data to last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2011 21:13:11 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Vivek Goyal <vgoyal@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] CFQ: rename ioc_data to last_cic

On Mon, 2011-06-06 at 05:02 +0200, Jens Axboe wrote:
> It's really io scheduler agnostic, but cfq is the only user. Lets leave
> the flexibility there.

So that agnosticism and flexibility is unused right now. This might
again have to do with my perspective, but understanding that
	ioc->ioc_data

(which really is rather opaque) basically meant (something like)
	ioc->cic_last

was a bit of an eye opener for me. But you have to maintain this code,
which makes this your decision, obviously.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/