linux-kernel - Re: [PATCH 2/2] staging: iio added missing "()" in kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2011 15:42:37 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	anish <anish198519851985@...il.com>
Cc:	gregkh@...e.de, jic23@....ac.uk, lucas.demarchi@...fusion.mobi,
	manuel.stahl@....fraunhofer.de, arnd@...db.de,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: iio added missing "()" in kmalloc

Hi,

On Mon, Jun 6, 2011 at 3:07 PM, anish <anish198519851985@...il.com> wrote:
> From: anish kumar <anish198519851985@...il.com>
>
> "()" was missing from kmalloc,so added it.
>
This is not required per-se, is it fixing a bug of some sort ?

 - Arnaud

> Signed-off-by: anish kumar <anish198519851985@...il.com>
> ---
>  drivers/staging/iio/industrialio-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
> index 3a82414..5251332 100644
> --- a/drivers/staging/iio/industrialio-core.c
> +++ b/drivers/staging/iio/industrialio-core.c
> @@ -136,7 +136,7 @@ static irqreturn_t iio_interrupt_handler(int irq, void *_int_info)
>
>  static struct iio_interrupt *iio_allocate_interrupt(void)
>  {
> -       struct iio_interrupt *i = kmalloc(sizeof *i, GFP_KERNEL);
> +       struct iio_interrupt *i = kmalloc(sizeof(*i), GFP_KERNEL);
>        if (i) {
>                spin_lock_init(&i->ev_list_lock);
>                INIT_LIST_HEAD(&i->ev_list);
> --
> 1.7.0.4
>
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/