linux-kernel - Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2011 22:49:23 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	anish <anish198519851985@...il.com>, devel@...verdev.osuosl.org,
	arnd@...db.de, lucas.demarchi@...fusion.mobi, gregkh@...e.de,
	linux-kernel@...r.kernel.org, jic23@....ac.uk,
	manuel.stahl@....fraunhofer.de
Subject: Re: [PATCH 1/2] staging: iio replaced kmalloc with local variables.

On Mon, Jun 06, 2011 at 09:13:29PM +0200, Geert Uytterhoeven wrote:
> On Mon, Jun 6, 2011 at 21:07, anish <anish198519851985@...il.com> wrote:
> > From: anish kumar <anish198519851985@...il.com>
> >
> > Replace kmalloc with local variables as it was un-necessary and
> 
> Is it really unnecessary?
> Or is this hardware that cannot transfer buffers on the stack?
> IIRC there have been similar problems with SCSI command buffers on the stack.

Yes.  You're right.  These buffers are not allowed to be stack
memory.  The documentation is the section "What memory is DMA'able?"
in Documentation/DMA-API-HOWTO.txt.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/