linux-kernel - Re: Seeing DMAR errors after multiple load/unload with SR-IOV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 07 Jun 2011 14:46:53 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Chris Wright <chrisw@...s-sol.org>
Cc:	padmanabh ratnakar <pratnakarlx@...il.com>,
	Alex Williamson <alex.williamson@...hat.com>,
	iommu <iommu@...ts.linux-foundation.org>,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: Seeing DMAR errors after multiple load/unload with SR-IOV

On Tue, 2011-06-07 at 06:38 -0700, Chris Wright wrote:
> I think we still leak the list entry though.  Bottom line is that we
> need to handle hotplug ADD_DEVICE and DEL_DEVICE notifications.  We
> happen to pick up ADD_DEVICE by accident, but it's all pretty sloppy. 

Yeah, keeping a list of possible stale 'pci_dev' pointers is stupid. We
should figure out the matching DMAR unit directly from the ACPI table at
ADD_DEVICE time, and store it in pdev->archdata.iommu.

I saw patches which were going in that direction...

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/