[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110609091213.GA13552@legolas.emea.dhcp.ti.com>
Date: Thu, 9 Jun 2011 12:12:14 +0300
From: Felipe Balbi <balbi@...com>
To: Felipe Balbi <balbi@...com>
Cc: Tatyana Brokhman <tlinder@...eaurora.org>, greg@...ah.com,
linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
ablay@...eaurora.org, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH/RESEND v15 1/10] usb: Add usb_endpoint_descriptor to be
part of the struct usb_ep
Hi again,
On Thu, Jun 09, 2011 at 11:32:10AM +0300, Felipe Balbi wrote:
> On Mon, Jun 06, 2011 at 02:40:45PM +0300, Tatyana Brokhman wrote:
> > Change usb_ep_enable() prototype to use endpoint descriptor from usb_ep.
> > This optimization spares the FDs from saving the endpoint chosen
> > descriptor. This optimization is not full though. To fully exploit this
> > change one needs to update all the UDCs as well since in the current
> > implementation each of them saves the endpoint descriptor in it's
> > internal (and extended) endpoint structure.
> >
> > Signed-off-by: Tatyana Brokhman <tlinder@...eaurora.org>
>
> now that I look at this patch carefully, won't this break all gadget
> drivers ? I mean, if I apply this patch, all gadget drivers will be
> using descriptor from struct usb_ep, but noone is actually assigning
> that pointer.
actually, I was wrong. The gadget driver is setting it, not the
controller anymore. I'll take this series in.
--
balbi
Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)
Powered by blists - more mailing lists