linux-kernel - Re: + sysctl-add-proc_dointvec_unsigned-handler-update.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Jun 2011 17:51:50 +0800
From:	Dave Young <hidave.darkstar@...il.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	ebiederm@...ssion.com
Subject: Re: + sysctl-add-proc_dointvec_unsigned-handler-update.patch added to
 -mm tree

On Fri, Jun 10, 2011 at 1:19 AM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> On Wed, Jun 8, 2011 at 11:45 PM,  <akpm@...ux-foundation.org> wrote:
>> --- a/kernel/sysctl.c~sysctl-add-proc_dointvec_unsigned-handler-update
>> +++ a/kernel/sysctl.c
>> @@ -2515,6 +2515,7 @@ int proc_dointvec_unsigned(struct ctl_ta
>>  {
>>        struct do_proc_dointvec_minmax_conv_param param = {
>>                .min = &zero,
>> +               .max = (int *) table->extra2,
>>        };
>>        return do_proc_dointvec(table, write, buffer, lenp, ppos,
>>                                do_proc_dointvec_minmax_conv, &param);
>
> This is still buggybecause "zero" is only 1 variable and max can be an array.
> Sysctl boundary comparisons are done element-by-element.

Where's the array use case?

-- 
Regards
dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/