linux-kernel - Re: [PATCHv3 -next] MFD: MFD module of DA9052 PMIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 11 Jun 2011 17:05:24 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Ashish Jangam <Ashish.Jangam@...tcummins.com>,
	"sameo@...nedhand.com" <sameo@...nedhand.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dajun Chen <Dajun.Chen@...semi.com>,
	"Ying-Chun Liu (PaulLiu)" <paul.liu@...aro.org>
Subject: Re: [PATCHv3 -next] MFD: MFD module of DA9052 PMIC driver

On Sat, Jun 11, 2011 at 04:35:42PM +0200, Arnd Bergmann wrote:
> On Saturday 11 June 2011 13:37:06 Mark Brown wrote:
> > On Sat, Jun 11, 2011 at 12:49:04PM +0200, Arnd Bergmann wrote:

> This is entirely pointless for this particular driver. While I can
> see good reasons to share idioms across similar drivers, this one
> just doesn't need it. The only two functions where the data is used
> AFAICT are da9052_irq_sync_unlock and da9052_irq_unmask, and both
> could replace the table lookup with a trivial computation.

Yes, indeed.

> I only looked at the first function in the list (da9052_adc_manual_read)
> and noticed that it doesn't have any users at all. It's certainly
> ok to export a complete API set when some functions belong together,
> but I had the impression that in this case it wasn't actually clear
> what the API is or should be.

> Maybe an explanation about what da9052_adc_manual_read does or why
> it's exported would be useful, I'm objecting the other exports.

There's been a hwmon driver posted which will use it I expect.  Many
PMICs have an ADC in them used for monitoring things like temperature
and supply rails, and typically also provide some generic inputs for
systems to use.  This is the sort of low rate ADC I'd like to see IIO be
able to handle but right now a custom interface like that is the
standard way to expose the ADC to the subsystems that can use it
(including machine specific code).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/