lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 12 Jun 2011 21:20:29 +0530
From:	Arvind R <arvino55@...il.com>
To:	Connor Hansen <cmdkhh@...il.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-kernel@...r.kernel.org, ravi@...ztechnologies.com,
	bluesmoke-devel@...ts.sourceforge.net
Subject: Re: [PATCH RESEND]Remove a warning for drivers/edac/i82975x_edac.c

Hi,
My system is broken currently, so I'm unable to check:(

But the foll. patch should fix the problem for 64 and 32 bits AND work
correct wrt.
to error-info. Would be glad if can check, please.

--- linux-2.6.39.1.orig/drivers/edac/i82975x_edac.c	2011-05-19 09:36:34 +0530
+++ linux-2.6.39.1/drivers/edac/i82975x_edac.c	2011-06-12 21:03:37 +0530
@@ -294,12 +294,12 @@
 	}

 	page = (unsigned long) info->eap;
-	if (info->xeap & 1)
-		page |= 0x100000000ul;
 	chan = page & 1;
-	page >>= 1;
 	offst = page & ((1 << PAGE_SHIFT) - 1);
-	page >>= PAGE_SHIFT;
+	page >>= 1;
+	if (info->xeap & 1)
+		page |= 0x80000000;
+	page >>= (PAGE_SHIFT - 1);
 	row = edac_mc_find_csrow_by_page(mci, page);

 	if (info->errsts & 0x0002)

- arvind
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ