linux-kernel - Re: [PATCH 2/5] staging/easycap: Fix thinko in "bars" module option description

Open Source and information security mailing list archives

Date:	Mon, 13 Jun 2011 15:27:17 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Kirill Smelkov <kirr@....spb.ru>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	Tomas Winkler <tomas.winkler@...el.com>,
	Mike Thomas <rmthomas@...olus.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] staging/easycap: Fix thinko in "bars" module option
 description

On Mon, Jun 13, 2011 at 04:18:29PM +0400, Kirill Smelkov wrote:
> Both bars=0 and bars=1 were described as meaning to display bars on
> signal lost. Actually bars=1 means "display bars", but bars=0 means
> display raw source as is (usually black screen).

Your description up here is much better than the one in the README.
Maybe just include yours and delete the original.

regards,
dan carpenter

> 
> Cc: Tomas Winkler <tomas.winkler@...el.com>
> Cc: Mike Thomas <rmthomas@...olus.org>
> Signed-off-by: Kirill Smelkov <kirr@....spb.ru>
> ---
>  drivers/staging/easycap/README |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/easycap/README b/drivers/staging/easycap/README
> index 16b8264..cd55eea 100644
> --- a/drivers/staging/easycap/README
> +++ b/drivers/staging/easycap/README
> @@ -60,7 +60,7 @@ Three module parameters are defined:
>  
>  debug      the easycap module is configured at diagnostic level n (0 to 9)
>  gain       audio gain level n (0 to 31, default is 16)
> -bars       0 =>  testcard bars when incoming video signal is lost
> +bars       0 =>  no testcard bars when incoming video signal is lost
>             1 =>  testcard bars when incoming video signal is lost (default)
>  
>  
> -- 
> 1.7.6.rc1
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives