linux-kernel - Re: [PATCH] ieee802154: Don't leak memory in ieee802154_nl_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2011 00:02:38 +0400
From:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-zigbee-devel@...ts.sourceforge.net,
	"David S. Miller" <davem@...emloft.net>,
	Sergey Lapin <slapin@...fans.org>,
	Maxim Osipov <maxim.osipov@...mens.com>
Subject: Re: [PATCH] ieee802154: Don't leak memory in ieee802154_nl_fill_phy

On 6/12/11, Jesper Juhl <jj@...osbits.net> wrote:
> In net/ieee802154/nl-phy.c::ieee802154_nl_fill_phy() I see two small
> issues.
> 1) If the allocation of 'buf' fails we may just as well return -EMSGSIZE
>    directly rather than jumping to 'out:' and do a pointless kfree(0).
> 2) We do not free 'buf' unless we jump to one of the error labels and this
>    leaks memory.
> This patch should address both.
>
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

Acked-by: Dmitry Eremin-Solenikov <dbaryshkov@...il.com>

David, please commit this.

-- 
With best wishes
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/